[Discover] Support for Security Solution flyout #192934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in useRootProfile, align root profile resolution in surrounding docs and single docs by using useRootProfile, and add getAppWrapper support to surrounding docs and single doc
davismcphee
added
release_note:skip
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: cc @davismcphee |
jughosta
reviewed
Sep 19, 2024
| ); | ||
| }; | ||
|
|
||
| export const getRenderDocViewerFlyout: DataSourceProfileProvider['profile']['getRenderDocViewerFlyout'] = |
There was a problem hiding this comment.
Or getDocViewerReplacement
logeekal
reviewed
Sep 23, 2024
| export function DiscoverGridFlyout(props: DiscoverGridFlyoutProps) { | ||
| const getRenderDocViewerFlyout = useProfileAccessor('getRenderDocViewerFlyout', { | ||
| record: props.hit, | ||
| }); |
There was a problem hiding this comment.
Thanks @davismcphee for creating this extension point. Althought this extension point works to display our flyout. I am still working on that. What it does not do is gives any handle of onClose event to the users of extension point.
For example, consider 2 use cases:
-
Users click
closebutton of the flyout, in that case we want toeffectthe expand icon change in the Discover DataGrid as seen below: -
User clicking on
expandbutton toggles the flyout but the extension point does not have access to know when user has clicked expand icon.
I think giving access to setExpandedDoc should be good enough and may also be more powerful than getRenderDocViewerFlyout.
What do you think?
| profileId: 'example-root-profile', | ||
| isExperimental: true, | ||
| profile: { | ||
| getRenderAppWrapper: (PrevWrapper, params) => { |
There was a problem hiding this comment.
So far this is working great. Still testing this. Will get back to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP.
Checklist
For maintainers